mChat Icons Menu

Move all mChat message icons to a convenient menu for a cleaner interface
User avatar
FranckTH
Donor
Posts: 15
Joined: 19 Nov 2016, 12:59
Location: Champagne (France)

Re: mChat Icons Menu

#21

Post by FranckTH » 07 Jan 2017, 12:01

The version 1.1.0 doesn't work on my board (i had the new event) i have no icons
<!-- INCLUDECSS ext/franckth/photoshop.exe -->

User avatar
Darloup
Donor
Posts: 62
Joined: 20 Oct 2016, 18:21
Location: Barranquilla (Colombia)

Re: mChat Icons Menu

#22

Post by Darloup » 07 Jan 2017, 12:38

Hello,

I'm using version 1.0.0 of this extension which works perfectly.

I must have missed something :
Note: Version 1.1.0 requires the event dmzx_mchat_messages_icons_after to be added to mChat 2.0.0, see last line here: https://github.com/kasimi/mChat/commit/ ... 6f9f177R28
What does version 1.1.0 do that version 1.0.0 doesn't do - especially if I have to modify mChat in order for it to work?

Regards,

Henry

Tarantino
Donor
Posts: 44
Joined: 21 Oct 2016, 12:59

Re: mChat Icons Menu

#23

Post by Tarantino » 07 Jan 2017, 15:50

kasimi wrote:
Tarantino wrote:Any news on this? :P
See first post for the latest version. Keep in mind that it requires a new event to be added to mChat. Read more about this in the download section of the first post.
Great! Thank you!

User avatar
kasimi
mChat developer
Posts: 329
Joined: 06 Oct 2016, 09:56
Contact:

Re: mChat Icons Menu

#24

Post by kasimi » 09 Jan 2017, 09:38

FranckTH wrote:The version 1.1.0 doesn't work on my board (i had the new event) i have no icons
Did you try clearing your board and browser caches? You might have to send me another test account so that I can have a look. :)
Darloup wrote:What does version 1.1.0 do that version 1.0.0 doesn't do - especially if I have to modify mChat in order for it to work?
In version 1.0.0 I copied the entire contents of the template file mchat_messages_icons.html to this extension. I'd have to update it every time mChat has an official update where this file is changed. In order to make this extension more future proof, instead of using its own copy, version 1.1.0 now re-uses mChat's code, but that is only possible if the event is available.

User avatar
Darloup
Donor
Posts: 62
Joined: 20 Oct 2016, 18:21
Location: Barranquilla (Colombia)

Re: mChat Icons Menu

#25

Post by Darloup » 09 Jan 2017, 10:30

Hola kasimi,
In version 1.0.0 I copied the entire contents of the template file mchat_messages_icons.html to this extension. I'd have to update it every time mChat has an official update where this file is changed. In order to make this extension more future proof, instead of using its own copy, version 1.1.0 now re-uses mChat's code, but that is only possible if the event is available.
Normally, whenever there is a new version, that latest version is supposed to encompass and solve any problems with previous versions.

You can't really tell anyone to stick to the previous version (1.0.0) if a new version is available (1.1.0) - that's totally illogical!

User avatar
kasimi
mChat developer
Posts: 329
Joined: 06 Oct 2016, 09:56
Contact:

Re: mChat Icons Menu

#26

Post by kasimi » 09 Jan 2017, 15:37

Sorry, I don't understand your problem. Why can't you keep using 1.0.0? It's a perfectly valid reason to do so if you can't or don't want to add the event yourself. People asked me to add features and so I did. Besides, the event will of course be added to mChat 2.0.1 which means you won't have to add it again in the future.

User avatar
kasimi
mChat developer
Posts: 329
Joined: 06 Oct 2016, 09:56
Contact:

Re: mChat Icons Menu

#27

Post by kasimi » 09 Jan 2017, 22:07

FranckTH wrote:The version 1.1.0 doesn't work on my board (i had the new event) i have no icons
I found the problem. In version 1.0.0 there's a file ext/kasimi/mchaticonsmenu/styles/prosilver/template/event/dmzx_mchat_messages_icons_add_before.html. In 1.1.0 this file was deleted. It seems you didn't delete the old version's folder during updating and instead overwrote all contents. So just make sure to delete that file, clear your board cache and everything should work fine. :)

By the way, it is always recommended to entirely delete an extension folder (after disabling the extension in the ACP of course) before uploading the new folder. :)

User avatar
kasimi
mChat developer
Posts: 329
Joined: 06 Oct 2016, 09:56
Contact:

Re: mChat Icons Menu

#28

Post by kasimi » 24 Mar 2017, 18:29

Version 1.1.1 is now available. See the first post for the download link.

There was a bug where the menu icon was displayed even if no buttons were available. This happened for example for guest users who can't perform any actions on any messages. Also the template files were updated to use Twig syntax. :+1:

Kong
Donor
Posts: 12
Joined: 21 Aug 2017, 22:48

Re: mChat Icons Menu

#29

Post by Kong » 23 Aug 2017, 01:36

kasimi wrote:
09 Jan 2017, 15:37
Besides, the event will of course be added to mChat 2.0.1 which means you won't have to add it again in the future.
So now that we're running mChat 2.0.1, does that mean we don't need to do the additional edit to get Icons 1.1.1 working? :+1: Great news! Love mChat and I'm so glad to see you continuing to work on updates like this one!

User avatar
kasimi
mChat developer
Posts: 329
Joined: 06 Oct 2016, 09:56
Contact:

Re: mChat Icons Menu

#30

Post by kasimi » 23 Aug 2017, 09:05

Kong wrote:
23 Aug 2017, 01:36
So now that we're running mChat 2.0.1, does that mean we don't need to do the additional edit to get Icons 1.1.1 working?
That's correct. :+1: Happy to hear you and your users like it. 🍻

Post Reply

Who is online

Users browsing this forum: No registered users and 1 guest