Polls doesn't work with rooms addon

Chat rooms for mChat with optional password protection and 1-on-1 chats
Post Reply

Does it work if you're turn on "show mChat in topics" (ucp)?

Poll ended at 08 Aug 2018, 17:40

Yes
1
50%
No...
1
50%
 
Total votes: 2

User avatar
BanterFace
Donor
Posts: 51
Joined: 01 Feb 2017, 12:42

Polls doesn't work with rooms addon

#1

Post by BanterFace » 25 Jul 2018, 17:40

PhpBB 3.2.1, digi with custom edits, mChat with custom edits, lots of other ext's (but disables for experiment). Enabled mChat Rooms and mChat in forums and topics disables able to sending poll's form with that message:
Image
Last edited by BanterFace on 25 Jul 2018, 18:36, edited 1 time in total.

User avatar
kasimi
mChat developer
Posts: 737
Joined: 06 Oct 2016, 09:56
Location: Germany
Contact:

Re: Polls doesn't work with rooms addon

#2

Post by kasimi » 25 Jul 2018, 17:47

This sounds like a problem with form tokens. Please test with the latest mChat 2.1.0, or apply these changes to your mChat code: https://github.com/kasimi/mChat/commit/ ... f1ece52e1d

User avatar
BanterFace
Donor
Posts: 51
Joined: 01 Feb 2017, 12:42

Re: Polls doesn't work with rooms addon

#3

Post by BanterFace » 25 Jul 2018, 18:37

Made edits from github in my 2.0.3, didn't help.

User avatar
kasimi
mChat developer
Posts: 737
Joined: 06 Oct 2016, 09:56
Location: Germany
Contact:

Re: Polls doesn't work with rooms addon

#4

Post by kasimi » 25 Jul 2018, 20:28

I don't have any other ideas at the moment. Let us know if you find a solution.

User avatar
kasimi
mChat developer
Posts: 737
Joined: 06 Oct 2016, 09:56
Location: Germany
Contact:

Re: Polls doesn't work with rooms addon

#5

Post by kasimi » 05 Aug 2018, 12:51

I might have a solution: after applying the fix I linked to in my last post, remove all event handlers for the core.add_form_key event from all mChat add-on extensions. Here is how to do this: in all mChat add-on extensions, open all event listener classes (.php files in the event folder). For each of these files, inline find 'core.add_form_key'. If you have a match, comment the entire line by adding // in front of them.

Let me know if it works.

User avatar
BanterFace
Donor
Posts: 51
Joined: 01 Feb 2017, 12:42

Re: Polls doesn't work with rooms addon

#6

Post by BanterFace » 05 Aug 2018, 13:05

Yeah.
That solution works fine, thanks kasimi!

User avatar
kasimi
mChat developer
Posts: 737
Joined: 06 Oct 2016, 09:56
Location: Germany
Contact:

Re: Polls doesn't work with rooms addon

#7

Post by kasimi » 05 Aug 2018, 13:08

Thanks for confirming. I will remove the code of the form token workaround from all the add-on extensions in their next updates.

Post Reply

Who is online

Users browsing this forum: Bing [Bot] and 1 guest