e-mail notifications from room invites can not be selected

Chat rooms for mChat with optional password protection and 1-on-1 chats
Bgagger
Donor
Posts: 45
Joined: 28 Nov 2018, 15:57

e-mail notifications from room invites can not be selected

#1

Post by Bgagger » 18 Feb 2019, 12:52

Seems to be another bug here.

Nobody, including me who has all possible mChat permissions can select the EMAIL checkbox option for 'Someone invites you to join an mChat room', under 'User control panel' -> 'Board preferences' -> 'Edit notification options'.

This would be very useful to be able to do, since invites to rooms are otherwise easily missed.

Checking the generated html code:

Code: Select all

- This code is only accessible to donors -
the option is disabled for some reason. But I can't find anything in the rooms code that appears to do that. So it might be a problem with the way core phpBB handles extension settings?

Again, if this could be looked into it would be much appreciated.

Painkiller88
Donor
Posts: 23
Joined: 01 Jan 2019, 12:41

Re: e-mail notifications from room invites can not be selected

#2

Post by Painkiller88 » 18 Feb 2019, 19:21

Hi,

I can confirm that, this is true. Mail notification for Room invations are greyed out.

Added in 4 minutes 58 seconds:
Update: i found a workaround till kasimi can check this.

if u select "mark all" the mail notification is checked even if it is unselectable, than u need to uncheck all u don't want but should work as a workaround for u and other admins. I know Kasimi is online half the day so he will see this very soon, give him some time ;)

Bgagger
Donor
Posts: 45
Joined: 28 Nov 2018, 15:57

Re: e-mail notifications from room invites can not be selected

#3

Post by Bgagger » 18 Feb 2019, 20:16

I'm afraid the workaround isn't working. The checkbox can be marked this way, but when the settings are saved, it does not become checked. It remains blank.

I can wait, but it's good to know this may be a proper bug and not just a configuration error on our part.

Painkiller88
Donor
Posts: 23
Joined: 01 Jan 2019, 12:41

Re: e-mail notifications from room invites can not be selected

#4

Post by Painkiller88 » 18 Feb 2019, 20:21

no, i checked this on mine and 3 other board of ext developers and ur right, this setting is disabled on all boards, so it is not your fault.

User avatar
kasimi
mChat developer
Posts: 985
Joined: 06 Oct 2016, 09:56
Location: Germany
Contact:

Re: e-mail notifications from room invites can not be selected

#5

Post by kasimi » 19 Feb 2019, 14:44

There's an easy explanation for this: the feature is not implemented, yet. :D

If an extension doesn't provide an email template file for its custom notification, the checkbox in the UCP notification options is grayed out.

@everyone, feel free to post your idea of an email template for a room invite and I will add it to the next Rooms update. In the meantime, if it's an essential feature for you, you can add it to your installation:
  1. Create an empty file ext/kasimi/mchatrooms/language/[language]/email/invite_notification.txt
  2. Put the subject on the first line, leave the 2nd line empty and start the message body on the 3rd line. Example:

    Code: Select all

    - This code is only accessible to donors -
  3. Open ext/kasimi/mchatrooms/notification/invite.php
  4. Find, around line 207:

    Code: Select all

    - This code is only accessible to donors -
  5. Replace with:

    Code: Select all

    - This code is only accessible to donors -
  6. Purge your board cache.

Painkiller88 wrote:
18 Feb 2019, 19:26
i found a workaround
I'd say this is a bug in phpBB, although a minor cosmetical one.

Bgagger
Donor
Posts: 45
Joined: 28 Nov 2018, 15:57

Re: e-mail notifications from room invites can not be selected

#6

Post by Bgagger » 19 Feb 2019, 21:00

That makes sense.

I've tried the patch though, and while the setting then becomes valid and can be saved, I'm not getting any e-mails sent when testing between two accounts. Both logged in or not.
I don't get any errors (nothing in the php log either) though and the invites work as normal.
I've sent a test e-mail from the phpbb installation (from the ACP), which confirms forum emails are configured correctly.

My template is as described for the txt file, just added a line.

Subject: mChat Room Invite - "{SITENAME}"

Hello {USERNAME},
You have a room invite in the forum chat. If you with to accept login to the forum and check your Notifications list to join the conversation.

I've followed all the steps. Not sure what's not clicking. But I guess for now we'll just have to wait for it to become part of an official update.
Thanks for clarifying what's going on. I hope the feature can be included soon.

User avatar
kasimi
mChat developer
Posts: 985
Joined: 06 Oct 2016, 09:56
Location: Germany
Contact:

Re: e-mail notifications from room invites can not be selected

#7

Post by kasimi » 21 Feb 2019, 08:55

Can you make sure that the checkbox for email notification in the receiver's UCP is still checked after submitting? Disable it, save, and enable it again.

Would anyone else be willing to test this?

Painkiller88
Donor
Posts: 23
Joined: 01 Jan 2019, 12:41

Re: e-mail notifications from room invites can not be selected

#8

Post by Painkiller88 » 21 Feb 2019, 11:37

i can test it in the evening.

Painkiller88
Donor
Posts: 23
Joined: 01 Jan 2019, 12:41

Re: e-mail notifications from room invites can not be selected

#9

Post by Painkiller88 » 21 Feb 2019, 19:23

Hi,

Tried this and it is working for me.
invite1.jpg
invite2.jpg
And yes, both checkboxes (notification and mail are checkable and were checked in this test)

Don't know if it is possible, but maybe there is a variable for the roomname i can add to the mail template like {ROOMNAME} :)

thanks in advance

EDIT:

when inviting a person to a room (private room in my case) i get an error but the invation is done correctly.

on firefox:
SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON da

on chrome:
i just run into a time-out (also a message from chat)

but in both cases the invation works

maybe there is something to improve when the implemention is officially here :)
You do not have the required permissions to view the files attached to this post.

User avatar
kasimi
mChat developer
Posts: 985
Joined: 06 Oct 2016, 09:56
Location: Germany
Contact:

Re: e-mail notifications from room invites can not be selected

#10

Post by kasimi » 21 Feb 2019, 21:41

Thanks for testing! The next Rooms update will have this feature included, to be published in the next days. :+1:
Painkiller88 wrote:
21 Feb 2019, 19:23
when inviting a person to a room (private room in my case) i get an error but the invation is done correctly.

on firefox:
SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON da
I don't see any errors in my Firefox console. Are you familiar with Firefox' developer tools to dig a little deeper? What are the contents of the server response that are failed to be parsed as JSON?

Post Reply

Who is online

Users browsing this forum: No registered users and 1 guest