White icons for dark styles

Chat rooms for mChat with optional password protection
Post Reply
nou nou
Donor
Posts: 32
Joined: 10 Oct 2017, 19:38

White icons for dark styles

#1

Post by nou nou » 19 Oct 2017, 16:47

Does something like this exist for mChatrooms, as well?

User avatar
kasimi
mChat developer
Posts: 369
Joined: 06 Oct 2016, 09:56
Contact:

Re: [HowTo] White icons for dark styles

#2

Post by kasimi » 19 Oct 2017, 16:58

The mChat Rooms icons should adapt to whatever icons are used in mChat itself, meaning that if $MCHAT_USE_WHITE_MESSAGE_ICONS is defined, Rooms icons will be white too. :+1:

nou nou
Donor
Posts: 32
Joined: 10 Oct 2017, 19:38

Re: [HowTo] White icons for dark styles

#3

Post by nou nou » 19 Oct 2017, 19:20

Ah, good to know.

Hmm... it doesn't appear the icons in the room list turn white?

User avatar
kasimi
mChat developer
Posts: 369
Joined: 06 Oct 2016, 09:56
Contact:

Re: [HowTo] White icons for dark styles

#4

Post by kasimi » 19 Oct 2017, 19:28

What style are you using? I tested in with Digi and it works fine.

nou nou
Donor
Posts: 32
Joined: 10 Oct 2017, 19:38

Re: [HowTo] White icons for dark styles

#5

Post by nou nou » 19 Oct 2017, 19:31

Subway.

I did seem to have some sort of manual solution for the white icons in place before. Hoping I didn't modify anything that broke your functionality.
But if it should work I'll dig a little deeper.

User avatar
kasimi
mChat developer
Posts: 369
Joined: 06 Oct 2016, 09:56
Contact:

Re: [HowTo] White icons for dark styles

#6

Post by kasimi » 19 Oct 2017, 19:44

I only have access to Subway for phpBB 3.1. If you send me a PM with the 3.2 version I'll have a look too. :+1:

nou nou
Donor
Posts: 32
Joined: 10 Oct 2017, 19:38

Re: [HowTo] White icons for dark styles

#7

Post by nou nou » 19 Oct 2017, 20:51

I'm still on 3.1 - does that version work fine for you?

User avatar
kasimi
mChat developer
Posts: 369
Joined: 06 Oct 2016, 09:56
Contact:

Re: [HowTo] White icons for dark styles

#8

Post by kasimi » 20 Oct 2017, 09:04

It doesn't, but the fix is easy:
  • Open ext/kasimi/mchatrooms/styles/prosilver/template/mchatrooms_rooms.html
  • Find MCHAT_USE_WHITE_MESSAGE_ICONS
  • Replace with definition.MCHAT_USE_WHITE_MESSAGE_ICONS
The fix will be included in the next mChat Rooms release. :+1:

nou nou
Donor
Posts: 32
Joined: 10 Oct 2017, 19:38

Re: [HowTo] White icons for dark styles

#9

Post by nou nou » 23 Oct 2017, 16:56

That was an easy fix indeed, thank you! :)

One tiny thing - the rotating progress wheel when switching rooms has an ugly white border around it.

User avatar
kasimi
mChat developer
Posts: 369
Joined: 06 Oct 2016, 09:56
Contact:

Re: White icons for dark styles

#10

Post by kasimi » 25 Oct 2017, 10:29

Can you test a different loading image? For example this one: https://www.tacticalpad.com/tacticalpad ... oading.gif

Location of the image: ext/kasimi/mchatrooms/styles/prosilver/theme/images/load.gif

I moved your posts to the Rooms forum.

Post Reply

Who is online

Users browsing this forum: Yahoo [Bot] and 0 guests